handle timers inside frame update

src/emulator.rs

@@ -112,17 +112,17 @@ where
 
     /// Emulation loop executes the fetch -> decode -> execute pipeline
     fn emulation_loop<T>(&mut self) -> Result<(), anyhow::Error> {
-        let mut timers_timer = Instant::now();
         let mut tick_timer = Instant::now();
         let target_fps: u128 = 60;
         loop {
-            // Handle sound and delay timer.
-            self.handle_timers(&mut timers_timer);
 
             let now = Instant::now();
             let elapsed_time = now.duration_since(tick_timer);
             let elapsed_ms = elapsed_time.as_millis();
             if elapsed_ms >= (1000 / target_fps) {
+                // Handle sound and delay timer.
+                self.handle_timers();
+
                 for _ in 0..=7 {
                     // fetch instruction & decode it
                     let instruction = self.fetch_instruction()?;
@@ -140,20 +140,15 @@ where
     }
 
     /// Handles the timers logic.
-    fn handle_timers(&mut self, start_time: &mut Instant) {
+    fn handle_timers(&mut self) {
-        // Handle 60hz timers
+        // Handle timers
-        let elapsed_time = start_time.elapsed().as_micros();
+        if self.delay_timer > 0 {
-        // 16667 us which is 1/60 of a second
+            self.delay_timer -= 1
-        if elapsed_time > 16667 {
+        }
-            if self.delay_timer > 0 {
+        if self.delay_timer > 0 {
-                self.delay_timer -= 1
+            self.delay_timer -= 1
-            }
+        } else {
-            if self.delay_timer > 0 {
+            self.do_beep()
-                self.delay_timer -= 1
-            } else {
-                self.do_beep()
-            }
-            *start_time = Instant::now()
         }
     }